Skip to content

fix isTaxYearLeapYear #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elijah-wright wants to merge 9 commits into from
Closed

fix isTaxYearLeapYear #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9739d20
fix isTaxYearLeapYear
elijah-wright May 30, 2025
bbae99b
remove TODO
elijah-wright May 30, 2025
223b94d
fix trailing space
elijah-wright May 30, 2025
4082629
Boolean => Int
elijah-wright Jun 4, 2025
6181108
add spec
elijah-wright Jun 4, 2025
a58d156
check for not equal 100 in divisible by 4 check
elijah-wright Jun 6, 2025
3d6cd5d
fix Modulo and XML
elijah-wright Jun 13, 2025
2ea4939
rewrite logic per @cjhskippy
elijah-wright Jun 16, 2025
932d41e
Apply spotless
cjhskippy Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 59 additions & 19 deletions direct-file/backend/src/main/resources/tax/constants.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,27 +47,67 @@
<Description>Whether the tax year is a leap year</Description>
<Derived>
<Switch>
<!-- TODO: replace this with the calc to determine leap year (e.g. divisible by 4, but not 100 unless also divisible by 400) -->
<Case>
<When>
<Any>
<Equal>
<Left>
<Dependency path="/taxYear" />
</Left>
<Right>
<Int>2024</Int>
</Right>
</Equal>
<Equal>
<Left>
<Dependency path="/taxYear" />
</Left>
<Right>
<Int>2028</Int>
</Right>
</Equal>
</Any>
<Equal>
<Left>
<Modulo>
<Left>
<Dependency path="/taxYear" />
</Left>
<Right>
<Int>400</Int>
</Right>
</Modulo>
</Left>
<Right>
<Int>0</Int>
</Right>
</Equal>
</When>
<Then>
<True />
</Then>
</Case>
<Case>
<When>
<Equal>
<Left>
<Modulo>
<Left>
<Dependency path="/taxYear" />
</Left>
<Right>
<Int>100</Int>
</Right>
</Modulo>
</Left>
<Right>
<Int>0</Int>
</Right>
</Equal>
</When>
<Then>
<False />
</Then>
</Case>
<Case>
<When>
<Equal>
<Left>
<Modulo>
<Left>
<Dependency path="/taxYear" />
</Left>
<Right>
<Int>4</Int>
</Right>
</Modulo>
</Left>
<Right>
<Int>0</Int>
</Right>
</Equal>
</When>
<Then>
<True />
Expand Down
Loading