Skip to content

Linux install #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Linux install #20

wants to merge 3 commits into from

Conversation

FreddieAkeroyd
Copy link
Member

Description of work

Add your own description here

To test

Which ticket does this PR fix?

Acceptance criteria

List the acceptance criteria for the PR

Code Review

  • Is the code of an acceptable quality?
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has developer documentation been updated if required?

@FreddieAkeroyd FreddieAkeroyd marked this pull request as ready for review February 11, 2025 00:34
Tom-Willemsen
Tom-Willemsen requested changes Feb 11, 2025
View reviewed changes
pyproject.toml
Comment on lines +30 to +38
"CaChannel@git+https://github.com/ISISComputingGroup/CaChannel",
# Send log messages to graylog
"graypy",
# genie_python will install ipython completers
"ipython",
# Getting user details from database
"mysql-connector-python",
"mysql-connector-python==8.4.0",
# Array support for CA calls
"numpy",
"numpy<2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be discussed in person/on teams etc - but we cannot use a git dep on pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tom-Willemsen Tom-Willemsen Tom-Willemsen requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FreddieAkeroyd @Tom-Willemsen