Document key-based auth #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Willemsen
force-pushed
the
key_based_auth
branch
from
8057e7c to
8a2108d
Compare
rerpha
reviewed
Aug 27, 2025
Comment on lines
+27
to
+29
| For the avoidance of doubt, the **public** key (`*.pub`) can be freely shared with everyone (for | ||
| example, by being copied onto instruments). Do not share your **private** key. The private key | ||
| is additionally encrypted using your selected password. |
There was a problem hiding this comment.
put this in a warning/caution admonitiion i'd say.
rerpha
reviewed
Aug 27, 2025
doc/tools/SSH-keys.md
Outdated
| ## Deploying the public key | ||
|
|
||
| - Add your public key to the [keys repository](https://github.com/ISISComputingGroup/keys). | ||
| - Ask a developer whose key is *already* deployed to run the deployment script, which will |
There was a problem hiding this comment.
which deployment script? we have many.
rerpha
reviewed
Aug 27, 2025
doc/tools/SSH-keys.md
Outdated
Comment on lines
66
to
68
| Firstly, if you intend to run a command across many instruments, it is worth getting that command | ||
| reviewed by another developer and running it together. This is **especially** true if you intend to | ||
| run a command as a privileged user. |
rerpha
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.