Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] UI/UX Data handling: Larger window and list view by default #7160

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 3, 2025

What do these changes do?

  • Larger window: Stanadalone window and access from Study Details
  • List view by default. Prettify list view: make less table like
  • Enable Delete call on folder

UIUX_Data

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Feb 3, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Feb 3, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 4, 2025 12:13
@odeimaiz odeimaiz added this to the Singularity milestone Feb 4, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] UI/UX Data handling: Larger window a list view by default 🎨 [Frontend] UI/UX Data handling: Larger window and list view by default Feb 4, 2025
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) February 4, 2025 15:40
Copy link

sonarqubecloud bot commented Feb 4, 2025

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (d4d8e65) to head (8f9a65b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7160   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files        1636     1636           
  Lines       63966    63966           
  Branches     1179     1179           
=======================================
  Hits        56076    56076           
  Misses       7578     7578           
  Partials      312      312           
Flag Coverage Δ *Carryforward flag
integrationtests 64.67% <ø> (-10.12%) ⬇️
unittests 85.95% <ø> (ø) Carriedforward from d4d8e65

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.51% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.39% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 74.09% <ø> (ø)
pkg_settings_library 90.71% <ø> (ø)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 90.33% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.92% <ø> (ø)
director_v2 91.29% <ø> (ø)
dynamic_scheduler 97.17% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.95% <ø> (ø)
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.22% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d8e65...8f9a65b. Read the comment docs.

Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just a couple of things...

  • do we want to ask for confirmation when deleting (specially folders)
  • does deletion work with multiselection?
    thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants