Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 5, 2025

What do these changes do?

Locally I did not manage to run the tracing setup, since it was disabled and I did not catch the issue. The tracing module only requires an initialize not a lifespan.
I have now correctly renamed it, to avoid future doubts.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Feb 5, 2025
@GitHK GitHK added a:dynamic-scheduler t:maintenance Some planned maintenance work labels Feb 5, 2025
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (d4d8e65) to head (fd8d858).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7165      +/-   ##
==========================================
- Coverage   87.66%   87.58%   -0.09%     
==========================================
  Files        1636     1277     -359     
  Lines       63966    53998    -9968     
  Branches     1179      651     -528     
==========================================
- Hits        56076    47293    -8783     
+ Misses       7578     6525    -1053     
+ Partials      312      180     -132     
Flag Coverage Δ
integrationtests 64.67% <50.00%> (-10.12%) ⬇️
unittests 85.56% <53.33%> (-0.39%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 74.12% <100.00%> (+0.03%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <50.00%> (ø)
api_server 90.55% <50.00%> (ø)
autoscaling 96.08% <50.00%> (ø)
catalog 90.33% <50.00%> (ø)
clusters_keeper 99.24% <50.00%> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <50.00%> (ø)
director 76.92% <50.00%> (ø)
director_v2 91.30% <50.00%> (+0.01%) ⬆️
dynamic_scheduler 97.17% <66.66%> (ø)
dynamic_sidecar 89.75% <50.00%> (ø)
efs_guardian 90.25% <50.00%> (ø)
invitations 93.28% <50.00%> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <50.00%> (ø)
resource_usage_tracker 89.17% <50.00%> (+0.21%) ⬆️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.19% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d8e65...fd8d858. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review February 5, 2025 07:37
@GitHK GitHK requested a review from giancarloromeo February 5, 2025 07:38
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@GitHK GitHK added this to the Singularity milestone Feb 5, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Feb 5, 2025
@GitHK
Copy link
Contributor Author

GitHK commented Feb 5, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-22.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-22.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-22.04)
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@pcrespov pcrespov merged commit aed987d into ITISFoundation:master Feb 5, 2025
90 of 94 checks passed
@GitHK GitHK deleted the pr-osparc-fix-tracing-setup branch February 5, 2025 09:29
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:dynamic-scheduler t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants