Skip to content

✨ adds notifications service (⚠️ devops) #7436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 65 commits into from
Apr 24, 2025

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 26, 2025

Devops ⚠️

What do these changes do?

This is the first in a series of pull requests aiming to transform the notifications-library into a standalone service which deals with notifying users via different means, like: email, bell notifications, flash messages. For details see https://github.com/ITISFoundation/private-issues/issues/39

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Mar 26, 2025
@GitHK GitHK added this to the The Awakening milestone Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 99.14163% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.72%. Comparing base (bb45023) to head (e11f9bb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7436      +/-   ##
==========================================
+ Coverage   87.66%   87.72%   +0.06%     
==========================================
  Files        1759     1767       +8     
  Lines       68178    68219      +41     
  Branches     1125     1125              
==========================================
+ Hits        59765    59848      +83     
+ Misses       8104     8062      -42     
  Partials      309      309              
Flag Coverage Δ
integrationtests 65.15% <ø> (-0.06%) ⬇️
unittests 86.92% <99.14%> (+0.07%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.91% <ø> (ø)
pkg_dask_task_models_library 97.10% <ø> (ø)
pkg_models_library 92.70% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.18% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 72.92% <ø> (ø)
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.66% <ø> (-0.06%) ⬇️
agent 96.46% <ø> (ø)
api_server 91.27% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.89% <ø> (+0.09%) ⬆️
director_v2 91.36% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.40% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.23% <ø> (+0.10%) ⬆️
storage 87.58% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb45023...e11f9bb. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK requested a review from pcrespov April 23, 2025 09:34
@GitHK GitHK modified the milestones: The Awakening, Pauwel Kwak Apr 23, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 24, 2025
@GitHK
Copy link
Contributor Author

GitHK commented Apr 24, 2025

@Mergifyio queue

Copy link
Contributor

mergify bot commented Apr 24, 2025

queue

🛑 The pull request has been merged manually

The pull request has been merged manually at 2155efe

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments, i'd be super happy if you could quickly comment on some ;)

@GitHK GitHK requested a review from mrnicegyu11 April 24, 2025 12:21
Copy link

@GitHK GitHK merged commit 2155efe into ITISFoundation:master Apr 24, 2025
94 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-add-notifications-service branch April 24, 2025 14:21
GitHK pushed a commit to ITISFoundation/osparc-ops-environments that referenced this pull request Apr 25, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants