-
Notifications
You must be signed in to change notification settings - Fork 36
✨ adds notifications service (⚠️ devops) #7436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ adds notifications service (⚠️ devops) #7436
Conversation
…ifications-service
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7436 +/- ##
==========================================
+ Coverage 87.66% 87.72% +0.06%
==========================================
Files 1759 1767 +8
Lines 68178 68219 +41
Branches 1125 1125
==========================================
+ Hits 59765 59848 +83
+ Misses 8104 8062 -42
Partials 309 309
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…ifications-service
…ifications-service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
@Mergifyio queue |
🛑 The pull request has been merged manuallyThe pull request has been merged manually at 2155efe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small comments, i'd be super happy if you could quickly comment on some ;)
services/notifications/src/simcore_service_notifications/api/rest/_health.py
Show resolved
Hide resolved
services/notifications/src/simcore_service_notifications/api/rpc/routing.py
Outdated
Show resolved
Hide resolved
services/notifications/src/simcore_service_notifications/clients/postgres/_liveness.py
Outdated
Show resolved
Hide resolved
|
Related PRs: * ITISFoundation/osparc-simcore#7436 Related Issues: * #1014
Devops⚠️
notifications
configuration osparc-ops-environments#1014What do these changes do?
This is the first in a series of pull requests aiming to transform the
notifications-library
into a standalone service which deals with notifying users via different means, like: email, bell notifications, flash messages. For details see https://github.com/ITISFoundation/private-issues/issues/39Related issue/s
How to test
Dev-ops checklist