Skip to content

WIP: Is34/catalog refactoring #7480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 4, 2025

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@pcrespov pcrespov self-assigned this Apr 4, 2025
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.10%. Comparing base (11a7e7b) to head (bff6724).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7480      +/-   ##
==========================================
- Coverage   87.40%   86.10%   -1.31%     
==========================================
  Files        1737     1318     -419     
  Lines       67032    54813   -12219     
  Branches     1138      589     -549     
==========================================
- Hits        58590    47196   -11394     
+ Misses       8121     7431     -690     
+ Partials      321      186     -135     
Flag Coverage Δ
integrationtests 56.42% <ø> (-8.74%) ⬇️
unittests 86.03% <0.00%> (-0.56%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.20% <0.00%> (-0.03%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.83% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog ∅ <ø> (∅)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.87% <ø> (+0.09%) ⬆️
director_v2 84.58% <ø> (-6.72%) ⬇️
dynamic_scheduler 97.35% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.23% <ø> (+0.10%) ⬆️
storage 87.17% <ø> (+0.03%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.62% <ø> (-0.29%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a7e7b...bff6724. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Apr 4, 2025

@pcrespov
Copy link
Member Author

Already implemented in #7491

@pcrespov pcrespov closed this Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant