-
Notifications
You must be signed in to change notification settings - Fork 35
♻️ preparation for osparc migration (merging deployments) (🗃️) #7700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
♻️ preparation for osparc migration (merging deployments) (🗃️) #7700
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7700 +/- ##
==========================================
+ Coverage 88.00% 88.77% +0.77%
==========================================
Files 1845 1552 -293
Lines 71182 61207 -9975
Branches 1220 546 -674
==========================================
- Hits 62645 54338 -8307
+ Misses 8185 6725 -1460
+ Partials 352 144 -208
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you try with the DBs already?
thanks!
packages/postgres-database/src/simcore_postgres_database/models/file_meta_data.py
Outdated
Show resolved
Hide resolved
...core_postgres_database/models/zzz_resource_tracker_service_runs__osparc_io_archive_202508.py
Show resolved
Hide resolved
I dont fully get what happens in this PR (what is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. Please double check mycomments. Specially theone of user_id
packages/postgres-database/src/simcore_postgres_database/models/file_meta_data.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/payments_methods.py
Show resolved
Hide resolved
...core_postgres_database/models/zzz_resource_tracker_service_runs__osparc_io_archive_202508.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can perhaps also delete user_to_projects
table?
Double check whether there are other tables that are not used....
TIP: Just check for references to the table variable with Vscode
|
What do these changes do?
zzz_resource_tracker_service_runs__osparc_io_archive_202508
where we will archive osparc service runs data.zzz
prefix is so it is in the end of all tables.PLAN for index increment:
NOTE!
resource_tracker_service_runs
user ID needs to be manually incremented (foreign key can not be introduced, because all anonymous users are always deleted)For migration:
For archiving the runs table:
Related issue/s
How to test
Dev-ops