-
Notifications
You must be signed in to change notification settings - Fork 30
🐛 Concurrent S3 bucket creation attempt #8045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Concurrent S3 bucket creation attempt #8045
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8045 +/- ##
===========================================
- Coverage 88.13% 68.30% -19.83%
===========================================
Files 1811 753 -1058
Lines 69732 35235 -34497
Branches 1258 176 -1082
===========================================
- Hits 61459 24068 -37391
- Misses 7909 11109 +3200
+ Partials 364 58 -306
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments.
Also I do not agree with the "it should be done in a separate script". Why?
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
7f873b9
into
ITISFoundation:master
What do these changes do?
This PR makes the setup of S3 in storage more robust, especially when trying to create the Bucket.
It would be ideal to move the creation out of the service, in a script, and not in the service logic.
Related issue/s
sto-worker
service fails to start due to concurrent S3 bucket creation during startup #8043How to test
Dev-ops