Skip to content

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 25, 2025

What do these changes do?

ReDoc

Before adding a new redirection /view/manifest, here are some improvements of viewer dispatcher API that we discovered while checking the functionality:

  • fixes missing query parameter in openapi specs image
  • improves error handling and message transmitted to front-end to avoid strange error as
image

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/with_dbs/04/studies_dispatcher

Dev-ops

🚨 check portal e2e links on each deploy

  • master
  • staging
  • production

@pcrespov pcrespov self-assigned this Aug 25, 2025
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 86.50519% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.83%. Comparing base (cca8054) to head (d068a69).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8257   +/-   ##
=======================================
  Coverage   87.82%   87.83%           
=======================================
  Files        1940     1945    +5     
  Lines       75317    75369   +52     
  Branches     1311     1311           
=======================================
+ Hits        66146    66198   +52     
  Misses       8776     8776           
  Partials      395      395           
Flag Coverage Δ
integrationtests 64.03% <56.05%> (+0.03%) ⬆️
unittests 86.50% <86.50%> (+<0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 87.37% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.15% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 71.13% <ø> (ø)
pkg_settings_library 90.17% <ø> (ø)
pkg_simcore_sdk 85.03% <ø> (+0.05%) ⬆️
agent 93.53% <ø> (ø)
api_server 91.91% <ø> (ø)
autoscaling 95.77% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.81% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 91.00% <ø> (-0.02%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.46% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 91.71% <ø> (-0.06%) ⬇️
storage 86.57% <ø> (+0.08%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.99% <86.50%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca8054...d068a69. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

mergify bot commented Aug 25, 2025

🧪 CI Insights

Here's what we observed from your CI run for d068a69.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@pcrespov pcrespov force-pushed the is1639/nih-portal-api branch from ce53e6b to 3c3f8c0 Compare August 25, 2025 16:23
@pcrespov pcrespov changed the title WIP: Is1639/nih portal api ♻️ Refactors studies-dispatcher before extending view api Aug 25, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Aug 25, 2025
@pcrespov pcrespov added this to the Voyager milestone Aug 25, 2025
@pcrespov pcrespov marked this pull request as ready for review August 25, 2025 16:27
@pcrespov pcrespov changed the title ♻️ Refactors studies-dispatcher before extending view api ♻️ Refactors studies-dispatcher before extending nih view's api Aug 25, 2025
@pcrespov pcrespov changed the title ♻️ Refactors studies-dispatcher before extending nih view's api ♻️ Refactors studies-dispatcher before extending nih portal's views api Aug 25, 2025
@pcrespov pcrespov enabled auto-merge (squash) August 25, 2025 16:30
@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 25, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pcrespov pcrespov force-pushed the is1639/nih-portal-api branch 3 times, most recently from 9a75ca1 to 622f24f Compare August 26, 2025 16:55
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@pcrespov pcrespov force-pushed the is1639/nih-portal-api branch from c78aca4 to 3978eab Compare September 4, 2025 16:26
@pcrespov pcrespov changed the title ♻️ Refactors studies-dispatcher before extending nih portal's views api ♻️ Refactors studies-dispatcher before extending nih portal's views api (🚨) Sep 4, 2025
@pcrespov
Copy link
Member Author

pcrespov commented Sep 4, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Sep 4, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

Copy link

sonarqubecloud bot commented Sep 4, 2025

@pcrespov pcrespov merged commit cfeede8 into ITISFoundation:master Sep 4, 2025
141 of 148 checks passed
@pcrespov pcrespov deleted the is1639/nih-portal-api branch September 4, 2025 22:22
@pcrespov
Copy link
Member Author

pcrespov commented Sep 24, 2025

🚨 checked in master. OK

@pcrespov
Copy link
Member Author

🚨 checked in aws-staging. OK

@pcrespov
Copy link
Member Author

🚨 checked in aws-production (using testing endpoint. OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants