🐛🗑️ Fixes validation of product vendor ui object and drops unused project_alias ⚠️

[pcrespov]

What do these changes do?

• 🗑️ Removes project_alias (requested by @odeimaiz)
• 🐛 Do not copy phone number from pre-registration since it is not verified (i.e. we do nt kow it is actually working) (reported by @odeimaiz)
• 🐛 Fixes validation error on products if product.vendor.ui is (reported by @pcrespov

{
	"url": "https://itis.swiss",
	"name": "IT'IS Foundation",
	"copyright": "© IT'IS Foundation",
	"license_url": "http://docs.osparc.io/#/docs/support/license",
	"invitation_form": true,
	"ui": {
		"logo_url": "https://raw.githubusercontent.com/ITISFoundation/osparc-simcore/refs/heads/master/services/static-webserver/client/source/resource/osparc/osparc-black.svg",
		"strong_color": "rgb(131, 0, 191)",
		"project_alias": "project"
	}
}

This fails validation upon startup like

    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/scu/.venv/lib/python3.11/site-packages/simcore_service_webserver/products/_web_events.py", line 47, in _load_products_on_startup
    product.name: product for product in await _service.load_products(app)
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/scu/.venv/lib/python3.11/site-packages/simcore_service_webserver/products/_service.py", line 31, in load_products
    raise InvalidConfig(msg) from err
servicelib.exceptions.InvalidConfig: Invalid product configuration in db:
 1 validation error for Product
vendor.ui.logoUrl
  Field required [type=missing, input_value={'logo': 'https://raw.git...oject_alias': 'project'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.11/v/missing

As a consequence, the templates do note render the log in the emails

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_*product*.py

Dev-ops

⚠️ When released: @pcrespov adds vendor config for corresponding products and tests emails

• master deploy
• staging deploy
• production deploy

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 99b907f.

✅ Passed Jobs With Interesting Signals

Pipeline	Job	Signal	Health on master	Retries	🔍 CI Insights	📄 Logs
CI	unit-tests	Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀		1	View	View

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.91%. Comparing base (2ac6d38) to head (99b907f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8266      +/-   ##
==========================================
+ Coverage   87.89%   87.91%   +0.01%     
==========================================
  Files        1933     1933              
  Lines       74941    74941              
  Branches     1309     1309              
==========================================
+ Hits        65871    65882      +11     
+ Misses       8677     8666      -11     
  Partials      393      393              

Flag	Coverage Δ
integrationtests	64.12% <37.50%> (+0.03%)	⬆️
unittests	86.56% <100.00%> (ø)

Components	Coverage Δ
pkg_aws_library	93.59% <ø> (ø)
pkg_celery_library	87.37% <ø> (ø)
pkg_dask_task_models_library	79.62% <ø> (ø)
pkg_models_library	93.09% <ø> (ø)
pkg_notifications_library	85.20% <ø> (-0.07%)	⬇️
pkg_postgres_database	88.02% <ø> (-0.01%)	⬇️
pkg_service_integration	70.19% <ø> (ø)
pkg_service_library	71.19% <ø> (ø)
pkg_settings_library	90.17% <ø> (ø)
pkg_simcore_sdk	85.03% <ø> (ø)
agent	93.53% <ø> (ø)
api_server	92.76% <ø> (+0.02%)	⬆️
autoscaling	95.77% <ø> (ø)
catalog	92.34% <ø> (ø)
clusters_keeper	99.13% <ø> (ø)
dask_sidecar	92.37% <ø> (ø)
datcore_adapter	97.94% <ø> (ø)
director	75.81% <ø> (ø)
director_v2	90.94% <ø> (+0.02%)	⬆️
dynamic_scheduler	96.27% <ø> (ø)
dynamic_sidecar	90.46% <ø> (ø)
efs_guardian	89.62% <ø> (ø)
invitations	91.44% <ø> (ø)
payments	92.61% <ø> (ø)
resource_usage_tracker	92.18% <ø> (ø)
storage	86.49% <ø> (ø)
webclient	∅ <ø> (∅)
webserver	88.08% <100.00%> (+0.03%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac6d38...99b907f. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This PR fixes validation issues with the product vendor UI object and removes the unused project_alias field as requested. The main issue was that the product validation was failing when vendor.ui contained a project_alias field that wasn't defined in the VendorUI TypedDict, causing email templates to not render logos properly.

Key Changes

• Removes project_alias field from VendorUI TypedDict and related models
• Updates email templates to use hardcoded "project" instead of dynamic project_alias
• Fixes product configuration model validation by removing alias generation and updating configuration

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/postgres-database/src/simcore_postgres_database/models/products.py	Removes project_alias from VendorUI TypedDict definition
packages/notifications-library/src/notifications_library/_models.py	Removes project_alias field from ProductUIData dataclass
services/web/server/src/simcore_service_webserver/products/_models.py	Updates Product model configuration and removes alias generation
services/web/server/src/simcore_service_webserver/statics/_events.py	Adds helper function for product data conversion with snake_to_camel
services/web/server/src/simcore_service_webserver/users/_accounts_service.py	Removes project_alias extraction from product vendor UI
packages/notifications-library/src/notifications_library/templates/*	Updates email templates to use hardcoded "project" text
packages/pytest-simcore/src/pytest_simcore/helpers/faker_factories.py	Removes project_alias from random product factory
services/web/server/src/simcore_service_webserver/products/_repository.py	Renames function from _to_domain to _db_to_domain

[matusdrobuliak66]

thanks

[sanderegg]

thanks

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[bisgaard-itis]

Great! Thanks