Skip to content

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 29, 2025

What do these changes do?

This PR introduces websocket support for the Support Conversations, enabling real-time updates for messages. The changes move websocket handling from the view layer to the data model layer for better separation of concerns.

SupportWithWS

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Aug 29, 2025
@odeimaiz odeimaiz added this to the Voyager milestone Aug 29, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 29, 2025
Copy link
Contributor

mergify bot commented Aug 29, 2025

🧪 CI Insights

Here's what we observed from your CI run for 4a9ce98.

🟢 All jobs passed!

But CI Insights is watching 👀

@odeimaiz odeimaiz requested a review from Copilot August 29, 2025 14:08
@odeimaiz odeimaiz marked this pull request as ready for review August 29, 2025 14:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces websocket support for the conversations feature, enabling real-time updates for messages and conversations. The changes move websocket handling from the view layer to the data model layer for better separation of concerns.

Key Changes

  • Move conversation message websocket listeners from UI components to the data model
  • Refactor conversation management to use conversation objects instead of just IDs
  • Update method names for better clarity (e.g., getConversationsfetchConversations)

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
osparc/data/model/Conversation.js Add websocket listeners and message management methods to the Conversation model
osparc/study/Conversations.js Remove message websocket handling and move constants to Conversation model
osparc/study/Conversation.js Refactor to use conversation objects and add websocket listeners
osparc/support/Conversation.js Extract share project checkbox logic and add conversation event listeners
osparc/support/Conversations.js Update method name for fetching conversations
osparc/store/ConversationsSupport.js Rename method from getConversations to fetchConversations

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 29, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Aug 29, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarqubecloud bot commented Sep 1, 2025

@odeimaiz odeimaiz merged commit 1df610c into ITISFoundation:master Sep 1, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants