-
Notifications
You must be signed in to change notification settings - Fork 31
🎨 [Frontend] Support Conversations: Listen to websocket #8276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 4a9ce98. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces websocket support for the conversations feature, enabling real-time updates for messages and conversations. The changes move websocket handling from the view layer to the data model layer for better separation of concerns.
Key Changes
- Move conversation message websocket listeners from UI components to the data model
- Refactor conversation management to use conversation objects instead of just IDs
- Update method names for better clarity (e.g.,
getConversations
→fetchConversations
)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
osparc/data/model/Conversation.js |
Add websocket listeners and message management methods to the Conversation model |
osparc/study/Conversations.js |
Remove message websocket handling and move constants to Conversation model |
osparc/study/Conversation.js |
Refactor to use conversation objects and add websocket listeners |
osparc/support/Conversation.js |
Extract share project checkbox logic and add conversation event listeners |
osparc/support/Conversations.js |
Update method name for fetching conversations |
osparc/store/ConversationsSupport.js |
Rename method from getConversations to fetchConversations |
services/static-webserver/client/source/class/osparc/study/Conversation.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/Conversation.js
Show resolved
Hide resolved
@Mergifyio queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…re into enh/ws-for-support
|
What do these changes do?
This PR introduces websocket support for the Support Conversations, enabling real-time updates for messages. The changes move websocket handling from the view layer to the data model layer for better separation of concerns.
Related issue/s
How to test
Dev-ops