-
Notifications
You must be signed in to change notification settings - Fork 32
Add a function_job_list_with_status endpoint 🎨 #8278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8278 +/- ##
==========================================
+ Coverage 87.79% 87.85% +0.06%
==========================================
Files 1940 1726 -214
Lines 75214 70177 -5037
Branches 1309 979 -330
==========================================
- Hits 66034 61656 -4378
+ Misses 8787 8219 -568
+ Partials 393 302 -91
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for 0f804f6. 🟢 All jobs passed!But CI Insights is watching 👀 |
services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions
services/api-server/tests/unit/api_functions/test_api_routers_function_jobs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/_service_function_jobs.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new endpoint to list function jobs with their status information, completing functionality to make the MM service job fetching faster. The implementation includes a list_function_jobs_with_status
endpoint that extends the existing function job listing with up-to-date status data and optimized output fetching.
- Adds new
list_function_jobs_with_status
endpoint across multiple service layers - Modifies existing
list_function_jobs
endpoint to use the new status-aware implementation - Refactors job output retrieval logic into dedicated service methods for better code organization
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
services/web/server/src/simcore_service_webserver/functions/_functions_service.py |
Implements core service logic for listing function jobs with status, including new decoder function |
services/web/server/src/simcore_service_webserver/functions/_functions_repository.py |
Updates repository layer to use status-aware database queries |
services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rpc.py |
Adds RPC endpoint wrapper for the new functionality |
services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py |
Implements REST API endpoint with include_status query parameter |
services/api-server/src/simcore_service_api_server/_service_function_jobs.py |
Adds service layer logic for status-aware job listing and output retrieval |
services/api-server/src/simcore_service_api_server/_service_jobs.py |
Refactors job output methods into JobService class |
packages/models-library/src/models_library/functions.py |
Defines new data models for function jobs with status information |
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/webserver/functions/functions_rpc_interface.py |
Adds RPC interface method for the new endpoint |
services/web/server/src/simcore_service_webserver/functions/_functions_service.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/_service_function_jobs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py
Show resolved
Hide resolved
|
@mergify refresh |
✅ Pull request refreshed |
@mergify queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
What do these changes do?
This is the final piece to make the MM service job fetching faster. It adds a new endpoint that extends the function job endpoint with also the up to date status of the job.
Related issue/s
ITISFoundation/osparc-issues#1899
How to test
Run MM service with and without
There are also tests in the api and webserver tests
Dev-ops
No changes