Skip to content

refactor: use std::unique_ptr (C++11) instead of deprecated std::auto_ptr #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

refactor: use std::unique_ptr (C++11) instead of deprecated std::auto_ptr #27

merged 2 commits into from
Apr 10, 2025

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Apr 5, 2025

Also, linux detection logic is fixed because linux macro is NOT ALWAYS defined on Linux; use __linux__ instead.

fix #25.

e-kwsm added 2 commits April 6, 2025 05:06
@e-kwsm
fix: fix detection of Linux
a59bcfa 
`linux` macro is NOT ALWAYS defined on Linux; use `__linux__` instead
@e-kwsm
refactor: use std::unique_ptr (C++11) instead of deprecated std::auto…
e3c080a 
…_ptr

fix IUPAC-InChI#25
janholstjensen
janholstjensen approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@janholstjensen janholstjensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Clean and to the point.

@janholstjensen janholstjensen merged commit 9347504 into IUPAC-InChI:main Apr 10, 2025
3 checks passed
@e-kwsm e-kwsm deleted the auto_ptr branch April 10, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janholstjensen janholstjensen janholstjensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std::auto_ptr is deprecated since C++11
2 participants
@e-kwsm @janholstjensen