Add reusable GitHub Actions workflows for PHP linting and unit testing #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to be finished. Any update planned? |
lippserd
force-pushed
the
php-workflow
branch
from
789ee07 to
b0c8b12
Compare
nilmerg
reviewed
Sep 30, 2025
Comment on lines
-46
to
-48
| sudo git clone -q --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-library.git /usr/share/icinga-php/ipl | ||
| echo "Fetching the latest snapshot of icinga-php-thirdparty..." | ||
| sudo git clone -q --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-thirdparty.git /usr/share/icinga-php/vendor |
There was a problem hiding this comment.
They were installed at the standard location, so that icingacli can load them without additional configuration, just in case it's required in the CI, is there a specific reason you've cloned them now in vendor/?
There was a problem hiding this comment.
No, sorry, not, icingacli, phpstan baselines, phpstan config, See: https://github.com/Icinga/icingadb-web/blob/main/phpstan.neon#L18
There was a problem hiding this comment.
And they contain the standard location, so that the config is also valid if phpstan is run locally
|
Can we possibly prevent using new names for the jobs? We'd have to update all and every branch protection rule as a result… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.