Skip to content

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Feb 12, 2025

resolves #275

@sukhwinder33445 sukhwinder33445 self-assigned this Feb 12, 2025
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Feb 12, 2025
@sukhwinder33445 sukhwinder33445 marked this pull request as draft February 12, 2025 08:07
@sukhwinder33445 sukhwinder33445 changed the title Improve schedule configuration Improve the ScheduleForm Feb 13, 2025
@sukhwinder33445 sukhwinder33445 marked this pull request as ready for review February 26, 2025 13:07
'required' => true,
'label' => $this->translate('Name')
'label' => $this->translate('Schedule Name'),
'placeholder' => 'e.g. working hours, on call, etc ...'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translate?

}
}

.icinga-form p.description {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.icinga-form is used for layout, this is style. For style a tag is usually not important, just a class suffices.

Suggested change
.icinga-form p.description {
.icinga-controls .description {

new Text($this->translate(
'Organize contacts and contact groups in a time based schedule and let them rotate'
. ' automatically. Multiple rotations can be added to your schedule to represent the rotating'
. ' members in your admin team. Schedules can be used as recipients of event rules.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This poses another question for me 🤣 : What is an admin team?

I think a less specific but still not too abstract example is required, to explain why multiple rotations are useful.

Something along this line:

Multiple rotations allow differing rotation patterns to override others.

But not quite this line, I just cannot come up with a better alternative right now. But I hope you get the idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:

Organize contacts and contact groups in a time based schedule and let them rotate
automatically. Multiple rotations can be added to your schedule to represent the rotating
members in your admin team
. You can add multiple rotations with different patterns to have
priority over others. Schedules can be used as recipients of event rules.

@sukhwinder33445 sukhwinder33445 force-pushed the improve-schedule-form branch from b17824b to 143e2f5 Compare April 7, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve schedule configuration
2 participants