Add column external_uuid to contact/contactgroup table
#216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
requested changes
Jun 11, 2024
sukhwinder33445
force-pushed
the
add-column-external-uuid
branch
from
767820c to
0a3cc97
Compare
julianbrost
requested changes
Jun 11, 2024
There was a problem hiding this comment.
You're missing the change in the full schema.sql file (looks like I've totally missed this before).
Also, if the NOT NULL constraints remain,
- a value should be set for existing rows.
- this should not be merged without Icinga/icinga-notifications-web#199, otherwise this would break creating contacts.
sukhwinder33445
force-pushed
the
add-column-external-uuid
branch
5 times, most recently
from
b997f95 to
bcc0bf0
Compare
raviks789
reviewed
Jun 12, 2024
sukhwinder33445
force-pushed
the
add-column-external-uuid
branch
from
bcc0bf0 to
2813f1e
Compare
sukhwinder33445
force-pushed
the
add-column-external-uuid
branch
from
2813f1e to
c630f50
Compare
julianbrost
reviewed
Jun 27, 2024
schema/pgsql/schema.sql
Outdated
Comment on lines
60
to
65
| CONSTRAINT pk_contact PRIMARY KEY (id), | ||
| UNIQUE (username) | ||
| UNIQUE (username), | ||
| UNIQUE (external_uuid), | ||
| CONSTRAINT pk_contact PRIMARY KEY (id) |
There was a problem hiding this comment.
I'm wondering why you reordered the constraints here. Also, in the rest of the schema file, so far the primary key is given first, I'd keep it that way (it also makes sense to me, one can say it's the most important constraint).
sukhwinder33445
force-pushed
the
add-column-external-uuid
branch
from
c630f50 to
ebe647d
Compare
|
This can wait, so far it is a stand-alone change without any dependencies to other branches (except the linked web branch). When the corresponding web branch is ready to be merged, this should be merged together with it. |
nilmerg
force-pushed
the
add-column-external-uuid
branch
from
ebe647d to
8f8e51c
Compare
|
I've only rebased and fixed the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #192
blocked by: Icinga/icinga-notifications-web#348