Skip to content

Conversation

jrauh01
Copy link
Contributor

@jrauh01 jrauh01 commented Aug 5, 2025

Add links on the tactical overview chart headers that open the lists that the donut charts represents considering the active filters.

Closes #820

@jrauh01 jrauh01 self-assigned this Aug 5, 2025
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Aug 5, 2025
@jrauh01 jrauh01 requested a review from lippserd August 5, 2025 08:59
jrauh01 added 3 commits August 6, 2025 11:54
Add an action link on the total hosts number that opens the list
that the host donut chart in the tactical overview represents
considering the active filters.
Add an action link on the total services number that opens the
list that the service donut chart in the tactical overview
represents considering the active filters.
@jrauh01 jrauh01 force-pushed the feature/tactical-header-links branch from e94b736 to 24e485f Compare August 6, 2025 09:55
@jrauh01 jrauh01 requested a review from flourish86 August 6, 2025 10:04
Copy link
Contributor

@flourish86 flourish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far.

We also discussed the hover effect for the donut label. Are you going to add that as well?

@flourish86 flourish86 self-requested a review August 6, 2025 16:04
Copy link
Contributor

@flourish86 flourish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, found it. icingaweb2/#5400

@jrauh01
Copy link
Contributor Author

jrauh01 commented Aug 7, 2025

Haha, found it. icingaweb2/#5400

Sorry, could have written it here. 😅

new HtmlElement(
'span',
Attributes::create(['class' => 'meta']),
new HtmlElement('span', null, new Text('Total ')),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was translated prior to this!

new HtmlElement(
'span',
Attributes::create(['class' => 'meta']),
new HtmlElement('span', null, new Text('Total ')),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add link to header of tactical for full list of hosts/services

3 participants