-
Notifications
You must be signed in to change notification settings - Fork 29
Add links to tactical overview headers #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add an action link on the total hosts number that opens the list that the host donut chart in the tactical overview represents considering the active filters.
Add an action link on the total services number that opens the list that the service donut chart in the tactical overview represents considering the active filters.
e94b736
to
24e485f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm so far.
We also discussed the hover effect for the donut label. Are you going to add that as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, found it. icingaweb2/#5400
Sorry, could have written it here. 😅 |
new HtmlElement( | ||
'span', | ||
Attributes::create(['class' => 'meta']), | ||
new HtmlElement('span', null, new Text('Total ')), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was translated prior to this!
new HtmlElement( | ||
'span', | ||
Attributes::create(['class' => 'meta']), | ||
new HtmlElement('span', null, new Text('Total ')), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here!
Add links on the tactical overview chart headers that open the lists that the donut charts represents considering the active filters.
Closes #820