Skip to content

Conversation

jrauh01
Copy link
Contributor

@jrauh01 jrauh01 commented Aug 7, 2025

If the problem toggle is created after the params are shifted, it redirects to the page without them. To solve this I simply moved the problem toggle before shifting the params.

Fixes #923

@jrauh01 jrauh01 self-assigned this Aug 7, 2025
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Aug 7, 2025
@jrauh01 jrauh01 changed the title Move problem toggle above shifting params Stop problem toggle to remove other params Aug 7, 2025
@jrauh01 jrauh01 requested a review from lippserd August 7, 2025 07:47
If the problem toggle is created after the params are shifted, it
redirects to the page without them. To solve this I simply moved
the problem toggle before shifting the params.
@jrauh01 jrauh01 force-pushed the fix/service-grid-toggle-removes-params-923 branch from 6afd96d to 716ebce Compare August 7, 2025 07:49
@nilmerg nilmerg added this to the 1.2.3 milestone Oct 15, 2025
@nilmerg nilmerg added the bug Something isn't working label Oct 15, 2025
@nilmerg nilmerg merged commit def4dce into main Oct 15, 2025
10 checks passed
@nilmerg nilmerg deleted the fix/service-grid-toggle-removes-params-923 branch October 15, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service Grid: activating "Problems only" removes limit=0,0

3 participants