Add 'scroll to top' button for History list
#1277
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrauh01
force-pushed
the
feature/scroll-to-top-button
branch
from
e9951a6 to
385be49
Compare
Adjust `#page-1` positioning so it sits in the parent’s top padding, preventing jump flicker when scrolling to it from the top of the list.
|
As discussed with @flourish86 and @lippserd I marked this PR as draft. Before continuing here, we agreed to consider making the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button links to a span with the id
#page-1at the top of the list. Additionally every 'Load More' click the button's href gets updated to keep the already opened pages open when scrolling to top via the button.Resolve #760