Remove THREE.Math in favor of THREE.MathUtils to sync with three.js/A-Frame master branch
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and A-Frame master
This was referenced Jan 5, 2023
|
I confirm the examples work with aframe 1.4.0, excepted the rain example but it's broken since aframe 1.1.0 #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
three.js changed its Math API to be called THREE.MathUtils recently, and the latest master branch of A-Frame reflects this, so this repo currently breaks A-Frame master (though is stable on 1.3.0). Updating this will reverse this situation and I am not sure how the maintainer would like to handle that - but I thought I'd make the issue known and the code available here.