Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default density to 1.25 #1146

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Set default density to 1.25 #1146

merged 1 commit into from
Dec 11, 2023

Conversation

felipeerias
Copy link
Collaborator

Lower the default density to avoid ugly visual artifacts.

On Pico and Quest 2, pages and images with very thin lines cause distortions and Moiré patterns when the density is too high. Lowering the density eliminates these effects.

Lower the default density to avoid ugly visual artifacts.

On Pico and Quest 2, pages and images with very thin lines
cause distortions and Moiré patterns when the density is too high.
Lowering the density eliminates these effects.
@felipeerias
Copy link
Collaborator Author

The visual issues can be appreciated with images like this one:

thin lines adobe

https://as1.ftcdn.net/v2/jpg/02/07/01/90/1000_F_207019089_pWCeZirf2dUaSXWmf1sbNS5hezjYX9gC.jpg


This is how this image is displayed on the Quest 2 with density 1.5.
Screenshot_20231210_230051

Detail showing the Moiré pattern:

density 1 5 oculus moire


This is how the image looks with density 1.25.

Screenshot_20231210_230248

Detail showing that the visual effect is gone:

density 1 25 oculus moire

It is hard to describe in a comment, but this situation looks much worse in reality because each eye sees a different effect.

Copy link
Collaborator

@HollowMan6 HollowMan6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aliasing in graphics is something we do need to consider, so that's why I mentioned here that it's good to have a default value for each kind of device to match the device resolution instead of specifying something default for all. #1086 (comment)

But anyway I can give a pass for this PR, maybe we can do that later. Unfortunately, I only have Meta Quest 2 so I can't really help with this issue.

@felipeerias
Copy link
Collaborator Author

Thanks @HollowMan6.

Yes, we need a complete solution with different values for each device and which also makes it easier for users to change those values.

For the moment, this is a safe default for the 1.5.2 release.

Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide examples so we could test in other devices?

@svillar svillar merged commit 0d50eea into main Dec 11, 2023
@svillar svillar deleted the felipeerias/defaultDensity125 branch December 11, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants