Top Sites in New Tab #1802
Merged
Top Sites in New Tab #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeerias
force-pushed
the
felipeerias/newTabTopSites
branch
2 times, most recently
from
87f2d1e to
efe912d
Compare
svillar
approved these changes
Mar 10, 2025
felipeerias
force-pushed
the
felipeerias/newTabTopSites
branch
2 times, most recently
from
a61d89b to
3c0aaef
Compare
|
Please rebase, also could you make this independent of #1801 which is controversial? That way we could land this beforehand |
felipeerias
force-pushed
the
felipeerias/newTabTopSites
branch
from
3c0aaef to
e45bb3e
Compare
|
|
felipeerias
force-pushed
the
felipeerias/newTabTopSites
branch
2 times, most recently
from
5d72f19 to
4bff3de
Compare
|
After removing the dependency with #1801 :
|
|
There are conflicts @felipeerias |
Add the Top Sites component, which provides a list of frequent and recent sites, as well as default and pinned ones. The default sites are empty for now, but we can add a few of them, including ones related to Wolvic.
felipeerias
force-pushed
the
felipeerias/newTabTopSites
branch
from
4bff3de to
10c6486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #1800
Add the Top Sites component, which provides a list of frequent and recent sites, as well as default and pinned ones.
The default sites are empty for now, but eventually we can add a few of them, including ones related to Wolvic.