Skip to content

Added ERP Hierarchical Grid #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 25, 2025
Merged

Added ERP Hierarchical Grid #7

merged 13 commits into from
Apr 25, 2025

Conversation

MarielaTihova
Copy link
Contributor

@MarielaTihova MarielaTihova added the ❌ status: awaiting-test PRs awaiting manual verification label Apr 15, 2025
@MayaKirova MayaKirova self-assigned this Apr 16, 2025
@MayaKirova MayaKirova changed the base branch from vnext to skrastev/sales-tabs April 16, 2025 14:24
@MayaKirova
Copy link

  1. There are some difference between the design in angular and this one.
    Angular(left) vs React (right)

image

  • The text in the buttons in the toolbar are all caps in angular, but not in react.
  • In the child grid, there is row selection in Angular, but not in react.
  • Some of the flags in the child grid Country column have shrink so much they are barely visible. Look at Germany and UK. If you resize the width to be smaller even further, they disappear.
  • The Address column in react has the same text but in different order, for example "Yonge Street 300C" vs "300C Yonge Street"
  1. Also routing for the main app should be fixed, so that when you start the root app it loads the correct sample. Currently it loads the view under src\app\views\erp-hgrid\erp-hgrid-view.tsx and not the one from the added sample.

@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 16, 2025
@mddragnev mddragnev self-requested a review April 22, 2025 13:29
Base automatically changed from skrastev/sales-tabs to vnext April 23, 2025 11:39
mddragnev
mddragnev requested changes Apr 23, 2025
View reviewed changes
@dkamburov dkamburov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 25, 2025
@dkamburov dkamburov merged commit 6d093fc into vnext Apr 25, 2025
1 check passed
@dkamburov dkamburov deleted the mtihova/erp-hgrid branch April 25, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mddragnev mddragnev mddragnev approved these changes

Assignees

@dkamburov dkamburov

@MayaKirova MayaKirova

Labels
✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarielaTihova @MayaKirova @mddragnev @dkamburov