Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Officer Card Designs #357

Merged
merged 2 commits into from
Feb 23, 2025
Merged

Officer Card Designs #357

merged 2 commits into from
Feb 23, 2025

Conversation

madison01108
Copy link

Status:

Description

inolasv
inolasv requested changes Feb 23, 2025
View reviewed changes
Copy link
Collaborator

@inolasv inolasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This is a nitpick but could the position be a little closer to the name of the officer (like in the figma/task)
  • Could you resolve this warning that shows up:
Screenshot 2025-02-23 at 12 55 44 PM

@madison01108 madison01108 merged commit 13e90f1 into migration Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inolasv inolasv inolasv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madison01108 @inolasv