Skip to content

IECoreScene CurvesPrimitiveEvaluator : fix vTangent() error #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaddon merged 1 commit into from
Jul 3, 2025
Merged

IECoreScene CurvesPrimitiveEvaluator : fix vTangent() error #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Fixes
- USDScene :
- Fixed writing of shutter values from cameras without a `shutter` parameter. The `shutter:open` and `shutter:close` attributes are now omitted instead of being written with Cortex's default -0.5, 0.5 shutter values.
- Fixed reading of shutter values from cameras without `shutter:open` and `shutter:close` attributes. The `shutter` parameter is now omitted instead of being created with USD's default 0, 0 shutter values.
- CurvesPrimitiveEvaluator : Fixed error in `Result::vTangent()` function causing tangent to point in opposite direction for curves with `Linear` interpolation.

10.5.x.x (relative to 10.5.15.0)
========
Expand Down
4 changes: 2 additions & 2 deletions src/IECoreScene/CurvesPrimitiveEvaluator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,8 @@ void CurvesPrimitiveEvaluator::Result::init( unsigned curveIndex, float v, const
{
m_coefficients[0] = 1.0f - m_segmentV;
m_coefficients[1] = m_segmentV;
m_derivativeCoefficients[0] = 1.0f;
m_derivativeCoefficients[1] = -1.0f;
m_derivativeCoefficients[0] = -1.0f;
m_derivativeCoefficients[1] = 1.0f;
m_vertexDataIndices[0] = m_varyingDataIndices[0] = o + i;
if( periodic )
{
Expand Down