Skip to content

Conversation

ivanimanishi
Copy link
Member

AtomsGaffer is currently claiming a range that has now been taken over by Gaffer 1.6.

https://github.com/Toolchefs/atomsGaffer/blob/master/include/AtomsGaffer/TypeIds.h

In the file you can see a note about updating cortex to claim the range in question, but that was never done.

I believe the solution is to change AtomsGaffer's range, and claim that new range here, so we don't run the risk of the same happening again in the future.

I'll update AtomsGaffer once the Cortex PR is approved.

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Cortex project's prevailing coding style and conventions.

@danieldresser-ie
Copy link
Contributor

Looks fine to me. I've added @johnhaddon as a reviewer in case he has any other opinions on how to allocate ranges, but this should be fine.

@ivanimanishi ivanimanishi changed the base branch from RB-10.5 to RB-10.6 September 19, 2025 15:48
@ivanimanishi ivanimanishi merged commit 88b5af7 into ImageEngine:RB-10.6 Sep 19, 2025
5 checks passed
@ivanimanishi ivanimanishi deleted the AtomsGafferTypeIds branch September 19, 2025 16:48
@ivanimanishi
Copy link
Member Author

Ended up merging it to RB-10.6 to simplify the process, given that typeIds change very rarely, and we just need to make sure nobody tries to use the reserved range for something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants