DisplayDriverServer : Support IPv4-only environments #1493
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In c357ea1, we switched from making an IPv4 connection, to an IPv6 one. This fixed some nasty lag on Windows, but it turns out that it also broke IPv4-only environments completely. So now we fall back to opening a v4 connection if the v6 connection fails.
|
Hmm, Windows CI is telling me I definitely messed something up. |
The previous commit was failing on Windows. Maybe we can't call `local_endpoint()` before `bind()`?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c357ea1, we switched from making an IPv4 connection, to an IPv6 one. This fixed some nasty lag on Windows, but it turns out that it also broke IPv4-only environments completely. So now we fall back to opening a v4 connection if the v6 connection fails.
@ericmehl, if you could check that the lag is still banished on Windows, that would be great. I think it should be fine because we open the v6 connection first still, but I'm a bit out of my comfort zone with this, so the more testing the better.