Skip to content

chore(deps): bump rand from 0.9.3 to 0.10.1 in /apps/desktop/src-tauri #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
Apr 24, 2026
Merged

chore(deps): bump rand from 0.9.3 to 0.10.1 in /apps/desktop/src-tauri #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bb7fd6
chore(deps): bump rand from 0.9.3 to 0.10.1 in /apps/desktop/src-tauri
dependabot[bot] Apr 24, 2026
d0e3616
refactor: drop rand for direct getrandom in pkce
Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/desktop/src-tauri/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/desktop/src-tauri/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ arc-swap = "1.7"
rustc-hash = "2.1"
sha2 = "0.10"
base64 = "0.22"
rand = "0.9"
getrandom = "0.3"
url = "2"

[dev-dependencies]
Expand Down
11 changes: 3 additions & 8 deletions apps/desktop/src-tauri/src/oauth_pkce/pkce.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

use base64::engine::general_purpose::URL_SAFE_NO_PAD;
use base64::Engine;
use rand::TryRngCore;
use sha2::{Digest, Sha256};

use super::errors::PkceError;
Expand All @@ -39,16 +38,14 @@ pub struct Pkce {
impl Pkce {
/// Generate a fresh verifier+challenge pair using the OS RNG.
///
/// The OS RNG (`rand::rngs::OsRng`, a thin wrapper over `getrandom`)
/// The OS RNG (`getrandom::fill`, backed by the platform CSPRNG)
/// is the only acceptable source: PKCE security relies on the
/// verifier being unguessable. Userspace PRNGs would not survive
/// a timing analysis of the SHA-256 challenge round-tripping the
/// network during the authorization phase.
pub fn generate() -> Result<Self, PkceError> {
let mut bytes = [0u8; RANDOM_BYTES];
rand::rngs::OsRng
.try_fill_bytes(&mut bytes)
.map_err(|e| PkceError::Rng(e.to_string()))?;
getrandom::fill(&mut bytes).map_err(|e| PkceError::Rng(e.to_string()))?;
let verifier = URL_SAFE_NO_PAD.encode(bytes);
let challenge = challenge_for(&verifier);
Ok(Self {
Expand All @@ -66,9 +63,7 @@ pub struct State(pub String);
impl State {
pub fn generate() -> Result<Self, PkceError> {
let mut bytes = [0u8; RANDOM_BYTES];
rand::rngs::OsRng
.try_fill_bytes(&mut bytes)
.map_err(|e| PkceError::Rng(e.to_string()))?;
getrandom::fill(&mut bytes).map_err(|e| PkceError::Rng(e.to_string()))?;
Ok(Self(URL_SAFE_NO_PAD.encode(bytes)))
}

Expand Down
Loading