[algorithm] Add some checks for null BaseProximity::SPtr#65
Merged
Conversation
epernod
reviewed
Aug 13, 2025
| if (dot(tip2Pt, normal) > 0_sreal) { | ||
| m_couplingPts.pop_back(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
what if edgeProx is null? should we sent a warning? or exit the loop?
Collaborator
Author
There was a problem hiding this comment.
I placed 2 warnings eventually.
- Notifies when shaftProx is null. It's unlikely because the CreateCenterProximity operations are straightforward.
- Notifies when edgeProx is null. With a valid shaftProx, this will happen if l_shaftGeom is not an EdgeGeometry.
If the two repos were merged into one, we could use the normal handler from the ConstraintGeometry repo. It could help avoid this downcasting.
epernod
added
pr: enhancement
pr: status to review
epernod
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the operations that return proximity pointers could be null. Some checks are put in place before they are used.