Fixed the behavior of backspace key when using search_key=None#95
Open
anishsane wants to merge 1 commit intoIngoMeyer441:developfrom
Open
Fixed the behavior of backspace key when using search_key=None#95anishsane wants to merge 1 commit intoIngoMeyer441:developfrom
anishsane wants to merge 1 commit intoIngoMeyer441:developfrom
Conversation
When search_key=None, if we press backspace as the first character, the
word is entered literally ("backspace") as the search term.
If the search_key is None and backspace is pressed, do nothing. (Do not
set the search_key to "backspace".)
Partially resolves IngoMeyer441#41
(The issue with accented characters mentioned in the issue description is not
handled.)
|
tab is causing the same problem and as you know left and right cursors cause crashes, potentially there are others as well So the definitive solution is probably to only allow printable characters with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When search_key=None, if we press backspace as the first character, the word is entered literally ("backspace") as the search term.
If the search_key is None and backspace is pressed, do nothing. (Do not set the search_key to "backspace".)
Partially resolves #41 (The issue with accented characters mentioned in the issue description is not handled.)