docs: fix README package doc links#87
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR adds ChangesContributing Documentation and Distribution
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes #83 by making the README's local documentation links resolvable in both the repository and the npm package.
CONTRIBUTING.mdlinked from the READMESDK-REFERENCE.mdandCONTRIBUTING.mdin the packagefileslist so npm README links resolve after publishVerification
node -e "const fs=require('fs'), path=require('path'); const files=['README.md']; let missing=[]; for (const file of files) { const text=fs.readFileSync(file,'utf8'); for (const m of text.matchAll(/\\[[^\\]]+\\]\\(([^)#][^)]+)\\)/g)) { const target=m[1].split('#')[0]; if (/^[a-z]+:/i.test(target)) continue; const resolved=path.resolve(path.dirname(file), target); if (!fs.existsSync(resolved)) missing.push(file+' -> '+m[1]); } } console.log('missing_relative_links='+missing.length); if (missing.length) { console.log(missing.join('\\n')); process.exit(1); }"npm pack --dry-run --json | jq -r '.[0].files[].path'git diff --checkNo full test suite was run because this only adds documentation/package metadata for README-linked files.
Summary by cubic
Fixes #83 by making README documentation links resolve in both the repo and the published npm package. Adds the missing contributing guide and packages both docs with the release.
CONTRIBUTING.mdreferenced by the README.SDK-REFERENCE.mdandCONTRIBUTING.mdinpackage.jsonfilesso README links work after publish.Written for commit ec0a785. Summary will update on new commits.
Note
Add CONTRIBUTING.md and include SDK-REFERENCE.md in published npm package
SDK-REFERENCE.mdandCONTRIBUTING.mdin thefilesarray so they are bundled in the published npm package.Macroscope summarized ec0a785.
Summary by CodeRabbit
Documentation
Chores