chore/admin dashboard template#53
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
10 issues found across 25 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="admin-dashboard/functions/apps-disconnect.ts">
<violation number="1" location="admin-dashboard/functions/apps-disconnect.ts:61">
P2: Silent error suppression on Composio cleanup. `.catch(() => {})` discards all fetch errors without logging, making orphaned Composio connections invisible to operators.</violation>
</file>
<file name="admin-dashboard/migrations/20260526150000_composio-apps-integration.sql">
<violation number="1" location="admin-dashboard/migrations/20260526150000_composio-apps-integration.sql:27">
P1: Hard delete of Zapier row silently cascade-deletes existing app_connections referencing it (FK has `on delete cascade`). Active user connections are destroyed without warning, rollback ability, or migration-time check.</violation>
</file>
<file name="admin-dashboard/functions/apps-poll.ts">
<violation number="1" location="admin-dashboard/functions/apps-poll.ts:88">
P2: `apps-poll` upserts `app_connections` using unvalidated `app_slug`, allowing mismatched/invalid app connection records to be written.</violation>
</file>
<file name="admin-dashboard/functions/apps-slack-list-channels.ts">
<violation number="1" location="admin-dashboard/functions/apps-slack-list-channels.ts:70">
P2: Channel listing is capped at 200 with no pagination, so many valid Slack channels become undiscoverable in larger workspaces.</violation>
</file>
<file name="admin-dashboard/functions/apps-slack-send-task.ts">
<violation number="1" location="admin-dashboard/functions/apps-slack-send-task.ts:89">
P2: `err(409, ...)` used when no connection row exists — 409 means conflict (wrong state), but a missing row is a 404 Not Found.</violation>
<violation number="2" location="admin-dashboard/functions/apps-slack-send-task.ts:109">
P2: User-provided task text is sent with Slack markdown parsing enabled, allowing mention/formatting injection in outbound messages.</violation>
</file>
<file name="admin-dashboard/src/features/apps/apps-page.tsx">
<violation number="1" location="admin-dashboard/src/features/apps/apps-page.tsx:25">
P2: Transient `apps-config` failures are treated as "Composio disabled", which can incorrectly disable all third-party app connections.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 16 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="admin-dashboard/src/features/apps/apps-grid.tsx">
<violation number="1" location="admin-dashboard/src/features/apps/apps-grid.tsx:87">
P2: Connected native integrations now show a Disconnect button that the backend rejects.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| </CardHeader> | ||
|
|
||
| <CardContent className="mt-auto flex items-center justify-between gap-3 pt-0"> | ||
| {app.connected ? ( |
There was a problem hiding this comment.
P2: Connected native integrations now show a Disconnect button that the backend rejects.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At admin-dashboard/src/features/apps/apps-grid.tsx, line 87:
<comment>Connected native integrations now show a Disconnect button that the backend rejects.</comment>
<file context>
@@ -85,22 +84,7 @@ export function AppsGrid({
- </Button>
- </>
- ) : app.connected ? (
+ {app.connected ? (
<>
<span
</file context>
…template # Conflicts: # registry.json
There was a problem hiding this comment.
1 issue found across 7 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="admin-dashboard/functions/apps-slack-send-task.ts">
<violation number="1" location="admin-dashboard/functions/apps-slack-send-task.ts:95">
P2: Database lookup errors are incorrectly returned as `slack_not_connected` (404), masking real backend failures as a missing Slack connection.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| .eq('workspace_id', workspace_id) | ||
| .eq('app_slug', 'slack') | ||
| .single() | ||
| if (connErr || !connRow) return err(404, 'slack_not_connected') |
There was a problem hiding this comment.
P2: Database lookup errors are incorrectly returned as slack_not_connected (404), masking real backend failures as a missing Slack connection.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At admin-dashboard/functions/apps-slack-send-task.ts, line 95:
<comment>Database lookup errors are incorrectly returned as `slack_not_connected` (404), masking real backend failures as a missing Slack connection.</comment>
<file context>
@@ -86,12 +92,12 @@ export default async function handler(req: Request): Promise<Response> {
.eq('app_slug', 'slack')
.single()
- if (connErr || !connRow) return err(409, 'slack_not_connected')
+ if (connErr || !connRow) return err(404, 'slack_not_connected')
if (connRow.status !== 'connected') return err(409, 'slack_not_connected')
</file context>
Suggested change
| if (connErr || !connRow) return err(404, 'slack_not_connected') | |
| if (connErr) return err(500, 'app_connection_lookup_failed', connErr.message) | |
| if (!connRow) return err(404, 'slack_not_connected') |
…egrations and outbound actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Switches the Apps page to real Composio OAuth for seven integrations and adds a “Send to Slack” action from Tasks. The catalog is Composio‑only, the Apps tab returns to the sidebar, and the sign‑in screen shows Google/GitHub icons; the template registry now highlights Composio integrations and outbound actions.
New Features
apps-config,apps-connect,apps-poll,apps-disconnect,apps-slack-list-channels,apps-slack-send-task.Migration
composio_toolkit_slug, reseeds catalog to Composio only; removes Stripe/OpenRouter/Zapier) or re-rundb_init.sql.COMPOSIO_API_KEYandCOMPOSIO_AUTH_CONFIG_*secrets, then deploy the six edge functions; see README “Connecting third‑party apps”.Written for commit d8f4c7b. Summary will update on new commits.