-
Notifications
You must be signed in to change notification settings - Fork 31
Add deprecation warning for the the dpctl.tensor submodule #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
the submodule will move to dpnp.tensor in a future release
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2191/index.html |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_24 ran successfully. |
| f"dpctl.tensor.{name} is deprecated; dpctl.tensor is deprecated " | ||
| "since dpctl 0.21.1 and will be removed in a future release. " | ||
| "Install dpnp and use 'import dpnp.tensor' instead.", | ||
| DeprecationWarning, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add tests per both deprecation warnings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's much of a need for tests, coverage remains the same anyway and it seems to work for me locally
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_49 ran successfully. |
As plans have now evolved to move the tensor submodule to dpnp, the tensor submodule will be deprecated in a coming minor version release