Skip to content

Update Windows version used by GitHub CI #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025
Merged

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 21, 2024

The PR is indented to remove a temporary pinning to "windows-2019" and to revert changes from #1833.
Besides Windows 2019 GitHub image is going to be fully unsupported by June 30, 2025.

The impacted workflows are moved to use "windows-2022" GH runners.
It requires updating conda_build_config.yaml where the version of the compiler as well as standard libraries have to be specified.
While {{ stdlib('c') }} is installing into build environment as an alignment with recipe's meta yaml from conda-forge (see dpctl#1868 as for reference).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 21, 2024
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/1841/index.html

@coveralls
Copy link
Collaborator

coveralls commented Feb 4, 2025

Coverage Status

coverage: 71.763%. remained the same
when pulling 007acf9 on use-windows-latest
into 667fe3e on master.

Copy link
Contributor

github-actions bot commented May 19, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the use-windows-latest branch from 7a8b0b8 to 25620cb Compare June 3, 2025 00:26
@antonwolfy antonwolfy changed the title Rolled back windows-latest usage Update Windows version used by GitHub CI Jun 3, 2025
@antonwolfy antonwolfy marked this pull request as ready for review June 3, 2025 00:56
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_8 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonwolfy antonwolfy merged commit a4aa964 into master Jun 3, 2025
66 of 67 checks passed
@antonwolfy antonwolfy deleted the use-windows-latest branch June 3, 2025 19:27
github-actions bot added a commit that referenced this pull request Jun 3, 2025
The PR is indented to remove a temporary pinning to "windows-2019" and
to revert changes from #1833.
Besides Windows 2019 GitHub image is going to be fully unsupported by
June 30, 2025.

The impacted workflows are moved to use "windows-2022" GH runners.
It requires updating `conda_build_config.yaml` where the version of the
compiler as well as standard libraries have to be specified.
While `{{ stdlib('c') }}` is installing into build environment as an
alignment with recipe's meta yaml from conda-forge (see
[dpctl#1868](IntelPython/dpctl#1868) as for
reference). a4aa964
@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants