-
Notifications
You must be signed in to change notification settings - Fork 22
Update Windows version used by GitHub CI #1841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/pull/1841/index.html |
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
7a8b0b8
to
25620cb
Compare
windows-latest
usage
Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_8 ran successfully. |
ndgrigorian
reviewed
Jun 3, 2025
vtavana
reviewed
Jun 3, 2025
Co-authored-by: Vahid Tavanashad <[email protected]>
ndgrigorian
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
added a commit
that referenced
this pull request
Jun 3, 2025
The PR is indented to remove a temporary pinning to "windows-2019" and to revert changes from #1833. Besides Windows 2019 GitHub image is going to be fully unsupported by June 30, 2025. The impacted workflows are moved to use "windows-2022" GH runners. It requires updating `conda_build_config.yaml` where the version of the compiler as well as standard libraries have to be specified. While `{{ stdlib('c') }}` is installing into build environment as an alignment with recipe's meta yaml from conda-forge (see [dpctl#1868](IntelPython/dpctl#1868) as for reference). a4aa964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is indented to remove a temporary pinning to "windows-2019" and to revert changes from #1833.
Besides Windows 2019 GitHub image is going to be fully unsupported by June 30, 2025.
The impacted workflows are moved to use "windows-2022" GH runners.
It requires updating
conda_build_config.yaml
where the version of the compiler as well as standard libraries have to be specified.While
{{ stdlib('c') }}
is installing into build environment as an alignment with recipe's meta yaml from conda-forge (see dpctl#1868 as for reference).