Extend `dpnp.pad` to support `pad_width` as a dictionary #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

antonwolfy wants to merge 3 commits into master from numpy_pad_dict

+92 −5

Contributor

antonwolfy commented Jul 23, 2025 •

edited

Loading

The PR adds support of pad_width keyword as a dictionary to align with the behavior in numpy.pad function.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?

antonwolfy added 2 commits

July 23, 2025 18:04


          Support pad_width as a dictionary

4a5992c


          Update the docstring and add test

474100b

antonwolfy added this to the 0.19.0 release milestone

antonwolfy self-assigned this


          Add PR to the changelog

0b1fd1c

Contributor

github-actions bot commented Jul 23, 2025

View rendered docs @ https://intelpython.github.io/dpnp/pull/2535/index.html

Contributor

github-actions bot commented Jul 23, 2025

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_20 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

Collaborator

coveralls commented Jul 23, 2025

coverage: 72.064% (-0.03%) from 72.097%
when pulling 0b1fd1c on numpy_pad_dict
into 9fc84dc on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov will be requested when the pull request is marked ready for review AlexanderKalistratov is a code owner

vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev will be requested when the pull request is marked ready for review vlad-perevezentsev is a code owner

vtavana Awaiting requested review from vtavana vtavana will be requested when the pull request is marked ready for review vtavana is a code owner

ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian will be requested when the pull request is marked ready for review ndgrigorian is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet