feat/chore: optimize plot queries and visit command #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreSchwang
commented
Feb 22, 2025
|
|
||
| @Override | ||
| public boolean accepts(final @NonNull Plot plot) { | ||
| return plot.isBasePlot() && plot.getOwners().size() > 0 && plot.getOwners().contains(owner); | ||
| return plot.isBasePlot() && plot.isOwner(owner); |
There was a problem hiding this comment.
the current Plot#getOwners#contains takes server-plots into account (so, if the server uuid is passed into this filter, and a plot is server owned, this filter would return true). Plot#isOwner uses Plot#getOwnerAbs and therefor would not produce the same result. Haven't seen an occurrence of a server plot being queried - not sure if this should just be changed either tbh
PierreSchwang
force-pushed
the
feat/chore/plotQueryAndVisit
branch
from
56a5bd6 to
9c64c2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/visitto remove overheadSubmitter Checklist
@since TODO.