Skip to content

fixed issue "depositPerUserLimit can be bypassed #5" #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alison024 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed issue "depositPerUserLimit can be bypassed #5" #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion contracts/OnChainSymmioVault.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ contract OnChainSymmioVault is
uint256 public collateralTokenDecimals;
WithdrawRequest[] public withdrawRequests;
uint256 public withdrawalPeriod;
mapping(address => uint256) public pendingWithdrawalAmount;

/// @custom:oz-upgrades-unsafe-allow constructor
constructor() {
Expand Down Expand Up @@ -77,7 +78,7 @@ contract OnChainSymmioVault is
);
SymmioVaultLpToken lpToken = SymmioVaultLpToken(lpTokenAddress);
require(
lpToken.balanceOf(_msgSender()) + amount <= depositPerUserLimit,
lpToken.balanceOf(_msgSender()) + amount + pendingWithdrawalAmount[_msgSender()] <= depositPerUserLimit,
"SymmioSolverDepositor: Deposit per user limit reached"
);

Expand Down Expand Up @@ -125,6 +126,7 @@ contract OnChainSymmioVault is
acceptedWithdawRequestTimestamp: 0
})
);
pendingWithdrawalAmount[_msgSender()] += amount;
emit WithdrawRequestEvent(
withdrawRequests.length - 1,
_msgSender(),
Expand All @@ -148,6 +150,7 @@ contract OnChainSymmioVault is
"SymmioSolverDepositor: Invalid status"
);
request.status = RequestStatus.Canceled;
pendingWithdrawalAmount[_msgSender()] -= request.amount;
SymmioVaultLpToken(lpTokenAddress).mint(_msgSender(), request.amount);
emit WithdrawRequestCanceled(id);
}
Expand Down Expand Up @@ -193,6 +196,9 @@ contract OnChainSymmioVault is
withdrawRequests[id].status = RequestStatus.Ready;
withdrawRequests[id].acceptedRatio = _paybackRatio;
withdrawRequests[id].acceptedWithdawRequestTimestamp = block.timestamp;
pendingWithdrawalAmount[
withdrawRequests[id].sender
] -= withdrawRequests[id].amount;
}

require(
Expand Down