CO-2677 - Add capability to generate, print, and delete Privacy Idea backup codes as an authenticator for a CO Person#525
Open
shaynasings wants to merge 3 commits into
Open
Conversation
shaynasings
changed the title
ioigoume
reviewed
Aug 2, 2023
| */ | ||
|
|
||
| public function generate() { | ||
| if($this->request->is('get')) { |
Contributor
There was a problem hiding this comment.
Since everything happens inside an if you should better reverse the logic.
public function generate() {
if(!$this->request->is('get')) {
// what to return here??
}
// the rest of the logic
}
| case PrivacyIDEATokenTypeEnum::TOTP: | ||
| $token['confirmed'] = false; | ||
| $TotpToken = new TotpToken(); | ||
| $TotpToken->save($token); |
Contributor
There was a problem hiding this comment.
What will happen if save fails?
| break; | ||
| } | ||
|
|
||
| if(!$jresponse->result->status) { |
Contributor
There was a problem hiding this comment.
this is probably not needed. The same check exists at line 193
| $results = $this->TotpToken->find('all', $args); | ||
|
|
||
| if(empty($results)) { | ||
| unset($args); |
Contributor
There was a problem hiding this comment.
prefer not to unset the $args but to re-initialize it.
$args = array();
…es as an authenticator for a CO Person
Collaborator
Author
|
rebased again latest develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…es as an authenticator for a CO Person