Skip to content

Change Tx to an associated data type #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Change Tx to an associated data type #5097

merged 1 commit into from
Jul 11, 2025

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jun 2, 2025

Description

This PR changes Tx from an associated type to an associated data type.

close #5000

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw force-pushed the jj/tx-data-family-2 branch 8 times, most recently from 6c4526a to c432c3b Compare June 19, 2025 15:45
@Soupstraw Soupstraw marked this pull request as ready for review June 26, 2025 12:35
@Soupstraw Soupstraw requested a review from a team as a code owner June 26, 2025 12:35
@Soupstraw Soupstraw force-pushed the jj/tx-data-family-2 branch 2 times, most recently from fa08622 to 8f2bc77 Compare June 26, 2025 12:44
@Soupstraw Soupstraw force-pushed the jj/tx-data-family-2 branch from 8f2bc77 to b601438 Compare June 26, 2025 15:02
@lehins
Copy link
Collaborator

lehins commented Jun 30, 2025

CI is still failing

@Soupstraw Soupstraw force-pushed the jj/tx-data-family-2 branch 5 times, most recently from 93df1ef to e072c41 Compare July 2, 2025 10:07
@Soupstraw Soupstraw force-pushed the jj/tx-data-family-2 branch 4 times, most recently from 197203d to b0b2c96 Compare July 10, 2025 12:00
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you!!!

@Soupstraw Soupstraw force-pushed the jj/tx-data-family-2 branch 2 times, most recently from 5273732 to 0508666 Compare July 11, 2025 10:00
@Soupstraw Soupstraw force-pushed the jj/tx-data-family-2 branch from 0508666 to 3585eec Compare July 11, 2025 10:01
Co-authored-by: Alexey Kuleshevich <[email protected]>
@Soupstraw Soupstraw force-pushed the jj/tx-data-family-2 branch from 3585eec to 769777f Compare July 11, 2025 10:21
@Soupstraw Soupstraw enabled auto-merge (rebase) July 11, 2025 10:40
@Soupstraw Soupstraw merged commit 5c56d03 into master Jul 11, 2025
130 of 132 checks passed
@Soupstraw Soupstraw deleted the jj/tx-data-family-2 branch July 11, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch Tx to a data family.
2 participants