Skip to content

Shelley: Move withdrawals draining from DELEGS to LEDGER #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

Shelley: Move withdrawals draining from DELEGS to LEDGER #5341

merged 2 commits into from
Oct 23, 2025

Conversation

@aniketd
Copy link
Contributor

@aniketd aniketd commented Oct 16, 2025 •
edited
Loading

Description

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@aniketd aniketd force-pushed the aniketd/shelley-withdrawals branch from 551ba54 to 6b22c6f Compare October 16, 2025 13:05
@aniketd aniketd marked this pull request as ready for review October 16, 2025 13:06
@aniketd aniketd requested a review from a team as a code owner October 16, 2025 13:06
neilmayhew
neilmayhew reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there should be a CDDL change that goes along with this.

@aniketd aniketd force-pushed the aniketd/shelley-withdrawals branch from 6b22c6f to cd62aa5 Compare October 17, 2025 13:53
teodanciu
teodanciu reviewed Oct 20, 2025
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but some tests are failing, they probably need to be adjusted to the changes.

lehins
lehins reviewed Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Once duplication is removed as suggestd we should be able to merge this PR.
Thank you!

@aniketd aniketd force-pushed the aniketd/shelley-withdrawals branch 4 times, most recently from 51dfb9d to 65cc479 Compare October 23, 2025 16:05
lehins
lehins approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you!

@aniketd @lehins
Move withdrawals-draining from DELEGS to LEDGER.
b39fca8 
* Remove `WIthdrawalsNotInRewardsDELEGS` pred-failure.
* Add `ShelleyWithdrawalsMissingAccounts` and
  `ShelleyIncompleteWithdrawals` to `ShelleyLedgerPredFailure`.
@aniketd @lehins
Shelley: Update changelog, version and bounds
59cf13b
@lehins lehins force-pushed the aniketd/shelley-withdrawals branch from 65cc479 to 59cf13b Compare October 23, 2025 20:50
@lehins lehins enabled auto-merge October 23, 2025 20:50
@lehins lehins merged commit 863ea2d into master Oct 23, 2025
121 of 122 checks passed
@lehins lehins deleted the aniketd/shelley-withdrawals branch October 23, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lehins lehins lehins approved these changes

@neilmayhew neilmayhew Awaiting requested review from neilmayhew

@teodanciu teodanciu Awaiting requested review from teodanciu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aniketd @neilmayhew @teodanciu @lehins