Remove tasty from all test suites except those in Byron

[neilmayhew]

Description

cardano-ledger-test was using a mixture of hspec and tasty which made it impossible to provide command line options. The mostly mechanical changes converts all the tasty tests to hspec ones, since we prefer hspec to tasty.

In addition, as a stopgap, I've created a small library called tasty-compat that provides the Tasty modules, types and functions used by Ledger, using the functionality of Hspec. It's a drop-in replacement for Tasty, just by changing the build-depends from tasty to tasty-compat.

I haven't made it work for Byron, because the test code there uses some advanced features of Tasty, but it's eliminated Tasty everywhere else in Ledger. Now we can use Hspec command-line options with every test executable except the three in Byron.

Checklist

• Commits in meaningful sequence and with useful messages.
• Tests added or updated when needed.
• CHANGELOG.md files updated for packages with externally visible changes.
  NOTE: New section is never added with the code changes. (See RELEASING.md).
• Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
  versioning process.
• Version bounds in .cabal files updated when necessary.
  NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
• Code formatted (use scripts/fourmolize.sh).
• Cabal files formatted (use scripts/cabal-format.sh).
• CDDL files are up to date (use scripts/gen-cddl.sh)
• hie.yaml updated (use scripts/gen-hie.sh).
• Self-reviewed the diff.

[teodanciu]

Looks good to me - I also compared these test logs with ones from before the refactoring, and indeed, all tests are being ran and the nesting is the same.

Thanks for finding and implementing the right solution (instead of my suggested tasty-hspec workaround!)
I guess this supersedes #5349, so we can close it probably.

[aniketd]

Thank you! 🙌

[neilmayhew]

I also compared these test logs with ones from before the refactoring, and indeed, all tests are being ran and the nesting is the same.

Thanks for doing that!

[lehins]

It really makes me happy to see reduction of tasty usage! Thank you for doing this

[neilmayhew]

I made quite a few changes, mostly as a result of the first one:

• Make tasty-compat a sublib of cardano-ledger-core
• Remove tasty manually from:
  • cardano-ledger-alonzo-test
  • cardano-ledger-binary
  • cardano-ledger-test
  • set-algebra
  • small-steps
  • vector-map

cardano-ledger-binary, set-algebra, small-steps, vector-map are dependencies of cardano-ledger-core and so can't use its tasty-compat sublibrary because that would create a circular dependency.

[lehins]

Awesome!!! Thank you!