Misc fixes #6230
Open
Misc fixes #6230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XXX Should be done in ouroboros-network.
move timestamp to pick up new version of iohk-monitoring
coot
requested changes
May 27, 2025
Comment on lines
+1064
to
+1073
| -- TODO remove and use defaultSyncTargets for next o-n-release. | ||
| defaultSyncTargets' :: PeerSelectionTargets -> PeerSelectionTargets | ||
| defaultSyncTargets' deadlineTargets = | ||
| deadlineTargets { | ||
| targetNumberOfActivePeers = 0, | ||
| targetNumberOfKnownBigLedgerPeers = 100, | ||
| targetNumberOfEstablishedBigLedgerPeers = 50, | ||
| targetNumberOfActiveBigLedgerPeers = 30 } | ||
|
|
||
|
|
There was a problem hiding this comment.
It's already there: IntersectMBO/ouroboros-network#5127.
btw, your sync targets are exactly the same as the ones in ouroboros-network-0.21.0.0.
There was a problem hiding this comment.
Not yet , but with IntersectMBO/ouroboros-network#5128 it will be.
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix genesis sync. target.
Bump chap timestamp so that input-output-hk/iohk-monitoring-framework#654 is included.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.