Skip to content

cardano-tracer: handle SIGINT same as cardano-node; ignore overflow in Forwarder backend lacking socket config #6267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

cardano-tracer: handle SIGINT same as cardano-node; ignore overflow in Forwarder backend lacking socket config #6267

merged 2 commits into from
Jul 1, 2025

Conversation

Icelandjack
Copy link
Contributor

@Icelandjack Icelandjack commented Jul 1, 2025 •
edited by mgmeier
Loading

Description

Two commits:

  • cardano-tracer: Use same signal handler for SIGINT as SIGTERM.
  • trace-dispatcher: Ignores overflow when there is no socket address specified.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@Icelandjack Icelandjack changed the title Baldurb/sigint cardano-node: Add signal handler to SIGINT, trace-dispatcher: ignore overflow without a socket Jul 1, 2025
@Icelandjack Icelandjack force-pushed the baldurb/sigint branch 4 times, most recently from 8ba3448 to 7d1aeb3 Compare July 1, 2025 12:19
mgmeier
mgmeier requested changes Jul 1, 2025
View reviewed changes
@mgmeier mgmeier changed the title cardano-node: Add signal handler to SIGINT, trace-dispatcher: ignore overflow without a socket cardano-tracer: handle SIGINT same as cardano-node; ignore overflow in Forwarder backend lacking socket config Jul 1, 2025
@Icelandjack Icelandjack requested a review from mgmeier July 1, 2025 13:57
@Icelandjack Icelandjack marked this pull request as ready for review July 1, 2025 14:22
@Icelandjack Icelandjack requested review from a team as code owners July 1, 2025 14:22
@mgmeier mgmeier force-pushed the baldurb/sigint branch 3 times, most recently from 08c3fee to 82e363a Compare July 1, 2025 16:07
@johnalotoski johnalotoski added this pull request to the merge queue Jul 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 1, 2025
@johnalotoski johnalotoski added this pull request to the merge queue Jul 1, 2025
Merged via the queue into master with commit 6a9b76f Jul 1, 2025
36 of 38 checks passed
@johnalotoski johnalotoski deleted the baldurb/sigint branch July 1, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgmeier mgmeier mgmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Icelandjack @mgmeier @johnalotoski