-
Notifications
You must be signed in to change notification settings - Fork 747
aarch64 support for cardano-node releases #6376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Yes please! |
|
Thanks @disassembler for the quick & cooperative response when we presented this on the IOG SPO Discord channel earlier today. I can personally confirm that ARM binary assets for |
|
ARM64v8 Docker images would be nice, too. |
|
@disassembler thank you for this. As we discussed during the incident, lots of folks run node on ARM. Armada Alliance has been doing a great job at compiling and distributing those binaries, but as @rphair already pointed out, in this case it would have helped greatly to have the binaries already here. Here's to hoping it will happen at some point🍻 |
angerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please!
We should also merge #5628 alongside this.
| cardano-node-*-win64.zip | ||
| cardano-node-*-macos.tar.gz | ||
| cardano-node-*-linux.tar.gz | ||
| cardano-node-*-arm.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest we append the arch to each release binary name other than Windows so that we can add both linux arm64 as well as darwin arm64:
cardano-node-*-linux-arm64.tar.gz
cardano-node-*-linux-x86_64.tar.gz
cardano-node-*-macos-arm64.tar.gz
cardano-node-*-macos-x86_64.tar.gz
cardano-node-*-win64.zip
| nix build --builders "" --max-jobs 0 ${{ steps.flake-metadata.outputs.LOCKED_URL }}#hydraJobs.x86_64-linux.musl.cardano-node-linux | ||
| cp result/cardano-node-*-*.tar.gz . | ||
| ;; | ||
| arm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can update this to add darwin arm64 as well.
|
This would be lovely! There quite a number of us running ARM nodes and it would enable us to respond much quicker during future incidents. |
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.