Skip to content

Conversation

@disassembler
Copy link
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@disassembler disassembler requested review from a team as code owners November 22, 2025 17:12
@TheStophe
Copy link

Yes please!

@rphair
Copy link

rphair commented Nov 23, 2025

Thanks @disassembler for the quick & cooperative response when we presented this on the IOG SPO Discord channel earlier today. I can personally confirm that ARM binary assets for cardano-node would have helped a number of stake pools respond more quickly to this week's emergency.

@wolf31o2
Copy link

ARM64v8 Docker images would be nice, too.

@adrem1
Copy link

adrem1 commented Nov 23, 2025

@disassembler thank you for this. As we discussed during the incident, lots of folks run node on ARM. Armada Alliance has been doing a great job at compiling and distributing those binaries, but as @rphair already pointed out, in this case it would have helped greatly to have the binaries already here.

Here's to hoping it will happen at some point🍻

Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please!

We should also merge #5628 alongside this.

Comment on lines 114 to 117
cardano-node-*-win64.zip
cardano-node-*-macos.tar.gz
cardano-node-*-linux.tar.gz
cardano-node-*-arm.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we append the arch to each release binary name other than Windows so that we can add both linux arm64 as well as darwin arm64:

            cardano-node-*-linux-arm64.tar.gz
            cardano-node-*-linux-x86_64.tar.gz
            cardano-node-*-macos-arm64.tar.gz
            cardano-node-*-macos-x86_64.tar.gz
            cardano-node-*-win64.zip

nix build --builders "" --max-jobs 0 ${{ steps.flake-metadata.outputs.LOCKED_URL }}#hydraJobs.x86_64-linux.musl.cardano-node-linux
cp result/cardano-node-*-*.tar.gz .
;;
arm)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update this to add darwin arm64 as well.

@OYSTERPOOL
Copy link

This would be lovely! There quite a number of us running ARM nodes and it would enable us to respond much quicker during future incidents.

@johnalotoski johnalotoski marked this pull request as draft November 26, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants