Make forkers more observable #1773
Open
+126
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
amesgen,
bladyjoker,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
jasagredo
force-pushed
the
js/tracing-forkers
branch
2 times, most recently
from
6f0481a to
0be9949
Compare
geo2a
approved these changes
Nov 25, 2025
Contributor
geo2a
left a comment
geo2a
left a comment
There was a problem hiding this comment.
I have a small comment regarding the use of the new TVar, otherwise looks good!
| , changelogDiffs = | ||
| ltliftA2 (doPrune s) (changelogDiffs orig) (changelogDiffs dblog) | ||
| } | ||
| Monad.void $ swapTVar (foeWasCommitted env) True |
Contributor
There was a problem hiding this comment.
Why not use writeTVar here, as in the corresponding place in the V2 implementation?
Contributor
Author
There was a problem hiding this comment.
Ah good point. Will change it
jasagredo
force-pushed
the
js/tracing-forkers
branch
from
0be9949 to
b45f224
Compare
jasagredo
force-pushed
the
js/tracing-forkers
branch
from
b45f224 to
7af3e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1710