Skip to content

Conversation

@Onyinyechi46
Copy link

Expanded the pull request template to include additional sections for implementation details, testing, breaking changes, and a checklist for contributors.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Expanded the pull request template to include additional sections for implementation details, testing, breaking changes, and a checklist for contributors.
Copy link

@Savissy Savissy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this, Princess

Copy link

@Savissy Savissy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this changes

@basetunnel
Copy link
Collaborator

Hi there. Could you please follow the existing pre-submit checklist for this PR? Specifically, is there a related issue motivating these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants