Skip to content

Plinth: Add Bounded typeclass and deriveBounded #7482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bezirg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Plinth: Add Bounded typeclass and deriveBounded #7482

bezirg wants to merge 2 commits into from

Conversation

@bezirg
Copy link
Contributor

@bezirg bezirg commented Dec 9, 2025

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@bezirg bezirg self-assigned this Dec 9, 2025
@bezirg bezirg marked this pull request as draft December 9, 2025 13:40
@bezirg bezirg force-pushed the bezirg/derive-bounded branch from 0b3bd07 to 2129536 Compare December 9, 2025 13:42
@bezirg bezirg marked this pull request as ready for review December 9, 2025 13:51
@bezirg bezirg requested a review from zliu41 December 9, 2025 13:52
@bezirg bezirg force-pushed the bezirg/derive-bounded branch from 2129536 to 77d2cc9 Compare December 15, 2025 14:05
@bezirg bezirg force-pushed the bezirg/derive-bounded branch from 77d2cc9 to d838673 Compare December 15, 2025 14:11
@zliu41 zliu41 requested a review from a team December 15, 2025 18:11
zliu41
zliu41 reviewed Dec 15, 2025
View reviewed changes
Copy link
Member

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this buys us. It seems using Haskell's Bounded is sufficient?

@bezirg
Copy link
Contributor Author

bezirg commented Dec 15, 2025 •
edited
Loading

I'm not sure what this buys us. It seems using Haskell's Bounded is sufficient?

I tried to use the Haskell one and I get the classic error of no available unfoldings

@zliu41
Copy link
Member

zliu41 commented Dec 15, 2025

There should be some plugin tests to verify that the plugin can compile the new Bounded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zliu41 zliu41 zliu41 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@bezirg bezirg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bezirg @zliu41