Skip to content

Address code review feedback: fix shell injection, remove dead code, improve error handling #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielsdrost7 merged 2 commits into from
Jan 7, 2026
Merged

Address code review feedback: fix shell injection, remove dead code, improve error handling #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfaab11
Initial plan
Copilot Jan 7, 2026
fd23d71
Address code review feedback: fix banner, Dockerfile improvements, wo…
Copilot Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions .docker/invoiceplane-banner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,6 @@ show_logo() {
EOF
}

# Helper function to display container info box
show_info_box() {
local container_type="${1:-Unknown}"
local user_name
local host_name

user_name=$(whoami 2>/dev/null || echo "unknown")
host_name=$(hostname 2>/dev/null || echo "unknown")

echo -e "${IPBLUE}╔════════════════════════════════════════════════════════════╗${NC}"
echo -e "${IPBLUE}║${NC} ${container_type}${IPBLUE}║${NC}"
echo -e "${IPBLUE}║${NC} Container: ${GREEN}${host_name}${NC} | User: ${YELLOW}${user_name}${NC} | Dir: ${GREEN}\w${NC}${IPBLUE}║${NC}"
echo -e "${IPBLUE}╚════════════════════════════════════════════════════════════╝${NC}"
}

# Helper function to show PHP version if available
show_php_version() {
if command -v php >/dev/null 2>&1; then
Expand Down Expand Up @@ -85,12 +70,12 @@ display_banner() {
echo -e "${IPBLUE}╚════════════════════════════════════════════════════════════╝${NC}"

# Show additional info
local user_name host_name pwd
local user_name host_name current_dir
user_name=$(whoami 2>/dev/null || echo "unknown")
host_name=$(hostname 2>/dev/null || echo "unknown")
pwd=$(pwd 2>/dev/null || echo "~")
current_dir=$(pwd 2>/dev/null || echo "~")

echo -e "Container: ${GREEN}${host_name}${NC} | User: ${YELLOW}${user_name}${NC} | Dir: ${GREEN}${pwd}${NC}"
echo -e "Container: ${GREEN}${host_name}${NC} | User: ${YELLOW}${user_name}${NC} | Dir: ${GREEN}${current_dir}${NC}"

# Display quick commands
show_quick_commands
Expand Down
Loading