Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issues #34 #35
fix issues #34 #35
Changes from 27 commits
03c1a19
12d7f35
28e6460
9522f2e
1d2e18b
f5bddc5
127de63
67c85c1
e810755
6d19044
19800bf
ac1a6e9
d0a1eba
fb1ca00
9e8e91a
4767273
7c5372f
092ccf5
204fdda
4622132
6366062
7382e93
768fa7c
f6c68a9
99237ab
0d69e86
bc496b0
8e2bf31
576f495
afbcb08
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所以做命名規則的轉換是在哪裡?
這邊我看起來沒有做。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因為我 df_func_name() 的命名轉換是依照 Python 的方式寫的,所以使用在 push_data() 和 on_data() 中,我會修改成寫在 parse_df_profile() 中,這樣的方式會將 sa 傳進來的
_[A-Z]?(I|O)[0-9]?
function.name 轉換成-[A-Z]?(I|O)[0-9]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
哦 ok